fix(ui): route file reveal actions through app command#96
Merged
vanloctech merged 1 commit intoJul 3, 2026
Merged
Conversation
The frontend still called the opener plugin directly in several queue and processing surfaces even though the backend already exposes an open_file_location command with platform-specific reveal behavior. This keeps the UI on the app command boundary while avoiding the broader ProcessingContext rewrite from the larger upstream PR. Constraint: Upstream already registers open_file_location in Rust, so the frontend can reuse that command without adding backend surface area. Rejected: Port PR vanloctech#94 wholesale | it pulls a larger ProcessingContext diff than needed for the Windows reveal fix. Confidence: high Scope-risk: narrow Directive: Keep file reveal UI actions routed through this helper unless the backend command is removed or renamed. Tested: biome targeted check for changed files; bun run tsc -b; cargo check in src-tauri after restoring the bundled yt-dlp binary; manual Show in folder on Windows custom build with a real downloaded sample-5s.mp4 file. Not-tested: macOS Finder reveal behavior; full Biome check in the clean Windows PR worktree because unrelated CRLF diagnostics affect untouched files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openFileLocation()helper that calls the existingopen_file_locationTauri command.revealItemInDirdirectly.Why
The app already has platform-aware Rust handling for
open_file_location. Reusing that command keeps reveal behavior centralized while avoiding extra frontend context churn.Tested
biome checktargeted to changed filesbun run tsc -bcargo checkinsrc-tauriafter restoring the bundled yt-dlp binary in the clean Windows worktreesample-5s.mp4, clicked Show in folder, Explorer opened the containing Downloads folderNotes
Full repo Biome on this Windows PR worktree is noisy because unrelated untouched files are checked out with CRLF line endings. The changed files pass targeted Biome after normalization.
Related: #94